Add plv8 #639
Merged
Add plv8 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
requested review from
EvanHStanton,
ianstanton and
vrmiguel
as code owners
|
Here's an example from when we previously built this. May give some clues for resolving the build failures: #194 |
I don't see anything much different there. Also seeing the weird failures in #637. The thing is, GitHub isn't showing any log output, but when I download the log archive and look through them, it's all there and everything passes/works. WTF GitHub? |
|
Turns out 3.2.2 needs a lot of RAM to build, and OOM killer was killing off our 8G VM. Updated #637 to 16G image and keeping an eye on it. Will update here when that's all happy and merged. |
Closed
theory
force-pushed
the
plv8
branch
2 times, most recently
from
2889ab4
to
555fa97
Compare
ianstanton
approved these changes
Jan 25, 2024
As of v3.2, the plv8 project no longer includes the `coffeescript` or `livescript` procedural languages. So add a plain old `plv8` package to replace the `plcoffee` package, which should be kept at v3.1.x and deprecated. Also build on `xlarge-16x16` to escape the merciless OOM killer, which doesn't like the super RAM-intensive plv8 build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v3.2, the plv8 project no longer includes the
coffeescriptorlivescriptprocedural languages. So add a plain oldplv8package to replace theplcoffeepackage, which should be kept at v3.1.x and deprecated.Also build on
xlarge-16x16to escape the merciless OOM killer, which doesn't like the super RAM-intensive plv8 build.