Refactor import-expression syntax regex matching #30
Conversation
| "0": { | ||
| "patterns": [ | ||
| { | ||
| "name": "import-expression.templ", |
There was a problem hiding this comment.
This outermost begin pattern matches from @ to the first opening parenthesis and provides the keyword.control.go to the @ and source.go to the function name/opening parenthesis. The pattern will end capture immediately after all of its children patterns have completed.
| "patterns": [ | ||
| { | ||
| "include": "#import-expression-start" | ||
| "name": "params.import-expression.templ", |
There was a problem hiding this comment.
This first inner pattern matches from the previous opening parenthesis to the closing and provides punctuation.definition.end.bracket.round.go to the closing. The function parameters inside are also marked with source.go.
| ] | ||
| }, | ||
| { | ||
| "name": "children.import-expression.templ", |
There was a problem hiding this comment.
Finally, this last inner pattern matches from the previous closing parenthesis and opening curly brace to the closing curly brace of the templ function. It provides the respective punctuation.brace.* to the curly braces and marks the captured children with the internal #template-node pattern.
Overview
Relates to a-h/templ#524
Previously, I fixed inline import expressions in #29 by breaking out empty (no children) expressions into their own rule and fixing both styles individually. After taking a deep-dive into the TextMate grammar engine that VSCode uses, I put together a much better approach that resolves inline/multi-line params and children/no-children import expressions all as one rule.
Before
After