Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removed Client Builder #4

Merged
merged 1 commit into from Jan 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

maddenpj commented Jan 2, 2013

A ClientBuilder class was used to create Tempodb clients that became unnecessary due to C# getting the default arguments feature. ClientBuilder was only to give sensible defaults, replaced by default arguments.

Also fixed Update Tests (They weren't respecting sending the whole series to server)

Contributor

myagley commented on 715a40d Jan 2, 2013

I'll merge this time. But, in the future we should split these into two changes:

  • Remove ClientBuilder
  • Update tests

myagley added a commit that referenced this pull request Jan 2, 2013

@myagley myagley merged commit 8ac3d06 into master Jan 2, 2013

@myagley myagley deleted the remove_builder branch Jan 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment