Fix shorthand payload marshaling when null is present
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been an obvious test case, but there was a lot going on... I'm going to add property based testing to this when I get the chance so that it'll help flush out any other embarrassing bugs
cretz
approved these changes
May 2, 2024
This was referenced Jul 5, 2024
dandavison
pushed a commit
that referenced
this pull request
Jul 5, 2024
**What changed?** I fixed an embarrassing bug in shorthand payload marshaling when `null` is present **Why?** Because it was a bug! **How did you test it?** I added a new test. I plan to add property-based testing to this shortly, but that will come in a new PR. **Potential risks** None
dandavison
added a commit
to temporalio/cli
that referenced
this pull request
Jul 5, 2024
Fixes #607 Bump `api` to pull in temporalio/api-go#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I fixed an embarrassing bug in shorthand payload marshaling when
nullis presentWhy?
Because it was a bug!
How did you test it?
I added a new test. I plan to add property-based testing to this shortly, but that will come in a new PR.
Potential risks
None