New event: update requested #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
added a commit
to dandavison/temporalio-sdk-core
that referenced
this pull request
Jan 28, 2024
rsync -auv ../api/temporal/ sdk-core-protos/protos/api_upstream/temporal/
dandavison
force-pushed
the
update-reapply
branch
from
21ddf2f
to
dffb802
Compare
cretz
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
This looks great to me and I hope in the near future, UpdateRequestedEventOrigin gets a UPDATE_REQUESTED_EVENT_ORIGIN_USER_REQUESTED or something to support admitted or general durability if the user wants it. To clarify, the SDKs should just ignore this event correct? If so, we'll want to remember server-side to set worker_may_ignore as true for this (though that's often more for backwards compat).
Sushisource
approved these changes
Jan 29, 2024
temporal/api/enums/v1/update.proto
Outdated
Comment on lines
58
to
60
| // UpdateRequestedEventOrigin records why an | ||
| // WorkflowExecutionUpdateRequestedEvent was written to history. Note that not | ||
| // all update requests result in a WorkflowExecutionUpdateRequestedEvent. |
There was a problem hiding this comment.
Suggested change
| // UpdateRequestedEventOrigin records why an | |
| // WorkflowExecutionUpdateRequestedEvent was written to history. Note that not | |
| // all update requests result in a WorkflowExecutionUpdateRequestedEvent. | |
| // Records why a | |
| // WorkflowExecutionUpdateRequestedEvent was written to history. Note that not | |
| // all update requests result in a WorkflowExecutionUpdateRequestedEvent. |
You're free of Go! You don't have to start the comment with the message name!
Lol, doesn't really matter, that rule just always drives me nuts 😆 . The an->a change is a real typo though.
yycptt
approved these changes
Jan 29, 2024
dandavison
added a commit
to dandavison/temporalio-sdk-core
that referenced
this pull request
Feb 16, 2024
rsync -auv ../api/temporal/ sdk-core-protos/protos/api_upstream/temporal/
dandavison
added a commit
to dandavison/temporalio-sdk-core
that referenced
this pull request
Feb 16, 2024
rsync -auv ../api/temporal/ sdk-core-protos/protos/api_upstream/temporal/
dandavison
added a commit
to temporalio/sdk-core
that referenced
this pull request
Feb 16, 2024
* Update protos from temporalio/api#351 rsync -auv ../api/temporal/ sdk-core-protos/protos/api_upstream/temporal/ * Ignore UpdateRequested event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new event
EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REQUESTEDfor update reapply.As explained in comments, this event will initially be restricted to updates reapplied during reset or replication. In the future we plan to use it for updates that are durable on admission.