Disable unnecessary linter rules #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Mar 13, 2024
Comment on lines
89
to
103
| // Optimistically create or update a Nexus service based on provided version. | ||
| // To update an existing service, get the current service record via the `GetNexusIncomingService` API, modify it | ||
| // and submit to this API. | ||
| // Set version to 0 to create a new service. | ||
| // Returns the updated service with the updated version, which can be used for subsequent updates. | ||
| rpc CreateOrUpdateNexusIncomingService(CreateOrUpdateNexusIncomingServiceRequest) returns (CreateOrUpdateNexusIncomingServiceResponse) { | ||
| } | ||
|
|
||
| // Delete an incoming Nexus service by name. | ||
| rpc DeleteNexusIncomingService(DeleteNexusIncomingServiceRequest) returns (DeleteNexusIncomingServiceResponse) { | ||
| } | ||
|
|
||
| // List all Nexus incoming services in the cluster. Use next_page_token in the response for pagination. | ||
| rpc ListNexusIncomingServices(ListNexusIncomingServicesRequest) returns (ListNexusIncomingServicesResponse) { | ||
| } |
There was a problem hiding this comment.
Not sure how, but I added them back
stephanos
approved these changes
Mar 13, 2024
buf.lock
Outdated
| @@ -5,9 +5,7 @@ deps: | |||
| owner: googleapis | |||
| repository: googleapis | |||
| commit: 28151c0d0a1641bf938a7672c500e01d | |||
| digest: shake256:49215edf8ef57f7863004539deff8834cfb2195113f0b890dd1f67815d9353e28e668019165b9d872395871eeafcbab3ccfdb2b5f11734d3cca95be9e8d139de | |||
There was a problem hiding this comment.
What's the effect of this?
There was a problem hiding this comment.
I don't know. It got auto-removed somehow. I added it back 🤷♂️
Comment on lines
89
to
103
| // Optimistically create or update a Nexus service based on provided version. | ||
| // To update an existing service, get the current service record via the `GetNexusIncomingService` API, modify it | ||
| // and submit to this API. | ||
| // Set version to 0 to create a new service. | ||
| // Returns the updated service with the updated version, which can be used for subsequent updates. | ||
| rpc CreateOrUpdateNexusIncomingService(CreateOrUpdateNexusIncomingServiceRequest) returns (CreateOrUpdateNexusIncomingServiceResponse) { | ||
| } | ||
|
|
||
| // Delete an incoming Nexus service by name. | ||
| rpc DeleteNexusIncomingService(DeleteNexusIncomingServiceRequest) returns (DeleteNexusIncomingServiceResponse) { | ||
| } | ||
|
|
||
| // List all Nexus incoming services in the cluster. Use next_page_token in the response for pagination. | ||
| rpc ListNexusIncomingServices(ListNexusIncomingServicesRequest) returns (ListNexusIncomingServicesResponse) { | ||
| } |
There was a problem hiding this comment.
Did you mean to do that in this PR?
Comment on lines
149
to
151
| string namespace = 3; | ||
| // Task queue to route requests to. | ||
| string target_task_queue = 4; | ||
| string task_queue = 4; |
There was a problem hiding this comment.
I assume for Nexus there's no problem with breaking changes.
There was a problem hiding this comment.
I just changed this to include the target because some validation logic on the server is incompatible with this change.
We should put these in fields in Spec object the same way the Cloud API did it.
I'm assuming you didn't want to make this change here @MichaelSnowden.
There was a problem hiding this comment.
Accidentally left in yeah
MichaelSnowden
force-pushed
the
snowden/lint
branch
from
0aa715b
to
d71e7c2
Compare
MichaelSnowden
force-pushed
the
snowden/lint
branch
from
d71e7c2
to
3cb1f06
Compare
stephanos
approved these changes
Mar 13, 2024
cretz
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Breaking changes
No.