Add execution duration to WorkflowExecutionInfo #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Apr 3, 2024
rodrigozhou
force-pushed
the
rodrigozhou/exec-duration-wf-info
branch
from
6397aba
to
28a9f37
Compare
cretz
reviewed
Apr 3, 2024
rodrigozhou
force-pushed
the
rodrigozhou/exec-duration-wf-info
branch
from
28a9f37
to
415b2ef
Compare
cretz
approved these changes
Apr 4, 2024
rodrigozhou
force-pushed
the
rodrigozhou/exec-duration-wf-info
branch
from
415b2ef
to
86861b3
Compare
yycptt
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add execution duration to WorkflowExecutionInfo
Why?
We don't want to have the UI infer the value, so it will be consistent to whatever the server populates.
Breaking changes
No.
Server PR
temporalio/temporal#5651