Rename Update Requested to Update Admitted #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Apr 2, 2024
| @@ -37,7 +37,7 @@ $(PROTO_OUT): | |||
| mkdir $(PROTO_OUT) | |||
|
|
|||
| ##### Compile proto files for go ##### | |||
| grpc: buf-lint api-linter buf-breaking clean go-grpc fix-path | |||
| grpc: buf-lint api-linter clean go-grpc fix-path | |||
There was a problem hiding this comment.
this will be re-enabled after merge
cretz
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Merged
dandavison
added a commit
to temporalio/temporal
that referenced
this pull request
Apr 17, 2024
## What changed? Rename field on internal update proto. ## Why? Consistency with the "requested" => "admitted" renaming started in temporalio/api#387 ## Potential risks None ## Is hotfix candidate? No
dandavison
added a commit
to dandavison/temporalio-sdk-core
that referenced
this pull request
May 7, 2024
dandavison
added a commit
to dandavison/temporalio-sdk-core
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Renamed "Update Requested" to "Update Admitted".
Why?
After some discussion, we came to the conclusion that the name should align with Update's wait stage in order to simplify the mental model for the user. "Requested" would be yet another concept, but "Admitted" (wait stage) already exists and should be used instead.
Breaking changes
Yes, but the renamed types are not used by the Server yet.
They are present in:
And subsequent PRs will adjust these accordingly.
Server PR
Not needed; these types are not used in Server yet.