Add firstRunId to WorkflowExecutionInfo #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Aug 2, 2024
|
Would like to wait here until server side implementation for temporalio/temporal#6348 is at least accepted and close to being worked on or completed. Concerned about adding API that won't be properly populated for a long time. |
cretz
approved these changes
Aug 8, 2024
yycptt
added a commit
to temporalio/temporal
that referenced
this pull request
Aug 8, 2024
## What changed? <!-- Describe what has changed in this PR --> - Expose workflow firstRunID in DescribeWorkflowExecution ## Why? <!-- Tell your future self why have you made these changes --> - #6348 - Server side impl of temporalio/api#439 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add firstRunId to WorkflowExecutionInfo
Why?
temporalio/temporal#6348
Breaking changes
NA
Server PR
NA