Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for schedule list query parameter #627

Closed
wants to merge 3 commits into from

Conversation

justinp-tt
Copy link
Contributor

What was changed

Support for schedule list query parameter

Checklist

  1. Closes [Feature Request] Support query for temporal schedule list #616

  2. How was this tested:

Added new tests

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@josh-berry josh-berry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a deep review since it's still in draft state, just one note for the help output.

@@ -525,6 +525,7 @@ The `temporal schedule list` command lists all Schedules in a namespace.

* `--long`, `-l` (bool) - Include detailed information.
* `--really-long` (bool) - Include even more detailed information that's not really usable in table form.
* `--query`, `-q` (string) - Filter results using a SQL-like query.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say what query language we're actually using / link to the language reference. You may want to wait on #561 to merge and then use the same text from that PR.

@justinp-tt
Copy link
Contributor Author

Comment for anyone perusing this: this PR currently needs a newer API version, but the released OSS doesn't yet have the newer API version. Discussions ongoing

…upport

# Conflicts:
#	temporalcli/commands.gen.go
#	temporalcli/commandsmd/commands.md
@justinp-tt justinp-tt closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support query for temporal schedule list
3 participants