Fix condition for rendering visibility config #467
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rendering visibility store config, instead of checking for .visibility key, it was checking for .default. Works when both your default and visibility store are same. Otherwise, doesn't.
What was changed
The condition for rendering visibility config in the server configmap was fixed.
Why?
This was a typo-like bug that was fixed.
Checklist
Closes Visibility config doesn't get rendered if visibility and default store types are different #466 .
How was this tested:
By rendering using helm template.
Any docs updates needed?
No.