Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: implement status #471

Merged

Conversation

shanginn
Copy link
Contributor

@shanginn shanginn commented Feb 20, 2024

Reason for This PR

closes: roadrunner-server/roadrunner#1872

Description of Changes

Added code to check status for status plugin.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review February 20, 2024 10:01
@rustatian rustatian self-assigned this Feb 20, 2024
@rustatian rustatian added A-tests Area: test (update, create, etc...) C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Feb 20, 2024
@rustatian rustatian changed the title implement status & test feature: implement status Feb 20, 2024
Copy link
Collaborator

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shanginn 👍

@rustatian rustatian merged commit 5f6de6c into temporalio:master Feb 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: test (update, create, etc...) C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Temporal plugin healthcheck
2 participants