Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_replaying attribute to WFActivation #126

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Jun 1, 2021

Why?

This is required in order for lang SDKs to be able to dedupe log messages and metrics.
See https://github.com/temporalio/proposals/blob/master/node/logging-and-metrics-for-user-code.md

@bergundy bergundy requested a review from Sushisource June 1, 2021 16:41
@bergundy bergundy requested a review from vitarb as a code owner June 1, 2021 16:41
@bergundy
Copy link
Member Author

bergundy commented Jun 2, 2021

I tested this and only got false, I see the TODO comment in the code, we'd need to address this for it to actually be useful.

@bergundy
Copy link
Member Author

bergundy commented Jun 3, 2021

I'm merging this despite the incorrectness of the value.
Let's prioritize fixing this since a lot of functionality relies on the is_replaying flag.
One thing I'm not sure of is if this flag should be set per activation or per activation job.
@Sushisource @mfateev @vitarb WDYT?

@bergundy bergundy merged commit a3a3c37 into master Jun 3, 2021
@bergundy bergundy deleted the activation-is-replaying branch June 3, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants