-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tonic, prost, otel to latest #782
Upgrade tonic, prost, otel to latest #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.
Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.
client/src/proxy.rs
Outdated
// let client = hyper::Client::builder().build(OverrideAddrConnector(self.target_addr.clone())); | ||
|
||
let client = Client::builder(TokioExecutor::new()).build_http(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing using the OverrideAddrConnector
, we'll need to make that work with the upgrade libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh missed it, working on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like not as straightforward as before with hyper 1.x.
Took a first stab it. But needs more understanding.
There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? |
At least this one looks related, looks like the timestamp type became copyable and hence is triggering this now. If there are also other, unrelated ones, fixing them in this PR is totally fine. |
Done fixed |
Upgrade Tonic, Prost, OTel deps
What was changed
Updated dependencies
tonic - 0.12.x
prost - 0.13.x
otel - 0.24.x
Why?
To upgrade to hyper 1.x ecosystem
Checklist
Closes #626
How was this tested:
To avoid mixing changes (Rust 1.80 clippy throwing lints)
NA