Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tonic, prost, otel to latest #782

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

h7kanna
Copy link
Contributor

@h7kanna h7kanna commented Jul 29, 2024

Upgrade Tonic, Prost, OTel deps

What was changed

Updated dependencies
tonic - 0.12.x
prost - 0.13.x
otel - 0.24.x

Why?

To upgrade to hyper 1.x ecosystem

Checklist

  1. Closes #626

  2. How was this tested:

cargo test
cargo integ-test

To avoid mixing changes (Rust 1.80 clippy throwing lints)

cargo clippy --all -- -D warnings -A clippy::clone-on-copy
  1. Any docs updates needed?
    NA

@h7kanna h7kanna requested a review from a team as a code owner July 29, 2024 19:19
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.

Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

Comment on lines 53 to 55
// let client = hyper::Client::builder().build(OverrideAddrConnector(self.target_addr.clone()));

let client = Client::builder(TokioExecutor::new()).build_http();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing using the OverrideAddrConnector, we'll need to make that work with the upgrade libs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh missed it, working on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like not as straightforward as before with hyper 1.x.
Took a first stab it. But needs more understanding.

@h7kanna
Copy link
Contributor Author

h7kanna commented Jul 29, 2024

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.

Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR?
I can put up another separate PR along with this.

@Sushisource
Copy link
Member

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.
Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? I can put up another separate PR along with this.

At least this one looks related, looks like the timestamp type became copyable and hence is triggering this now. If there are also other, unrelated ones, fixing them in this PR is totally fine.

@h7kanna
Copy link
Contributor Author

h7kanna commented Jul 29, 2024

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.
Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? I can put up another separate PR along with this.

At least this one looks related, looks like the timestamp type became copyable and hence is triggering this now. If there are also other, unrelated ones, fixing them in this PR is totally fine.

Done fixed

@Sushisource Sushisource enabled auto-merge (squash) July 29, 2024 23:04
@Sushisource Sushisource enabled auto-merge (squash) July 29, 2024 23:07
@Sushisource Sushisource merged commit 2bc8d7f into temporalio:master Jul 29, 2024
6 checks passed
@h7kanna h7kanna deleted the update-prost-tonic-otel branch July 29, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update to tonic 0.10
2 participants