Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CloseConnection to Close #140

Merged
merged 2 commits into from
May 27, 2020
Merged

Rename CloseConnection to Close #140

merged 2 commits into from
May 27, 2020

Conversation

alexshtin
Copy link
Member

  1. Rename CloseConnection to Close,
  2. Rename leftover Shutdown to Stop,
  3. Fix comments.

@alexshtin alexshtin requested a review from mfateev May 22, 2020 20:35
@alexshtin alexshtin merged commit 8bcb763 into temporalio:master May 27, 2020
@alexshtin alexshtin deleted the feature/rename-close-connection branch May 27, 2020 00:49
muralisrini pushed a commit to muralisrini/sdk-go that referenced this pull request Feb 4, 2024
@robholland
Fix encrypted-payloads data converter behaviour for local activity re…
5853906 
…sults (temporalio#140)

Fixes a bug which caused local activity results to not be encrypted in the history.

Refactor to set metadata on payloads, this avoids trying to decrypt a payload that hasn't been encrypted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfateev mfateev mfateev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexshtin @mfateev