Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proto payload conveter selection logic #387

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix proto payload conveter selection logic #387

merged 1 commit into from
Mar 24, 2021

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Mar 24, 2021 •
edited
Loading

Description, Motivation and Context

What was changed:
Fix proto payload conveter selection logic.

Motivation & Context:
ProtoPayloadConverter was wrongly chosen for the types with Marshal() ([]byte, error) method.

How has this been tested?

Run existing tests.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alexshtin alexshtin enabled auto-merge (squash) March 24, 2021 03:33
@alexshtin alexshtin merged commit cec615e into temporalio:master Mar 24, 2021
@alexshtin alexshtin deleted the feature/fix-proto-payload-converter branch March 24, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfateev mfateev mfateev approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

@vitarb vitarb Awaiting requested review from vitarb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexshtin @mfateev