Support executing local activities by name #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Previous commit was enforcing local activities to be registered into the
worker to be ran. However, current behavior is that code like
ExecuteLocalActivity(ctx, func() error {
return nil
})
is actually valid meaning local activity registration is optional when
you pass down the activity function directly.
This commits bring backs the old ExecuteLocalActivity behavior when the
activity passed is a func and tries to load the activity func from the
registry when we pass a string.
lminaudier
force-pushed
the
execute-local-activities-by-name
branch
from
c8850b0
to
00db9ac
Compare
Previous commits have removed validation of functions passed to ExecuteLocalActivity.
Sushisource
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
The change replicates the behavior of
ExecuteActivityforExecuteLocalActivityto allow executing local activities by supplying funcs or func names.In the process,
ExecuteLocalActivityis using the activity registry to lookup the activity function by name when needed.One question I have is that this could be potentially considered a breaking change because right now, it seems local activities executions don't seem to rely on the registry meaning that potentially, you don't have to register local activities in your worker? I still have to test if that is true and if so, if this is a documented behaviour.It seems that's indeed the case when I look at tests.Why?
This PR attempts to fix #354 to allow executing local activities by using the activity name similarly to non local activities.
Checklist
workflow.ExecuteLocalActivity#354Todo