-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Update handler dynamically #500
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
65620a7
to
b9a2a1b
Compare
src/Workflow.php
Outdated
* public function handler() | ||
* { | ||
* Workflow::registerUpdate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a little strange for the example to be registering the handler in a function called handler
which is also the workflow method. Maybe just call the function exampleWorkflow
or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the function wrapper for all Workflow::register* methods.
…al(), Workflow::registerUpdate()
What was changed
Added
Workflow::registerUpdate($name, $handler, $validator)
to register updates dynamicallyChecklist