Link workflow run spans together #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
commented
Oct 1, 2021
Sushisource
commented
Oct 1, 2021
Sushisource
force-pushed
the
link-run-spans
branch
4 times, most recently
from
4f4e55a
to
6996cc0
Compare
bergundy
reviewed
Oct 4, 2021
packages/worker/src/worker.ts
Outdated
| for (const j of rest.jobs) { | ||
| if (j.startWorkflow != null) { | ||
| const ctx = await extractSpanContextFromHeaders(j.startWorkflow.headers ?? {}); | ||
| if (ctx != null && linkedContext == null) { |
There was a problem hiding this comment.
Again these are undefineds not null.
I'll add a lint rule to prohibit using ==.
There was a problem hiding this comment.
I wouldn't just b/c we still need it for not overly verbose checking of null/undef in protos
Sushisource
force-pushed
the
link-run-spans
branch
2 times, most recently
from
fd86014
to
0f3a480
Compare
bergundy
reviewed
Oct 6, 2021
Sushisource
force-pushed
the
link-run-spans
branch
2 times, most recently
from
835eb01
to
a1d382c
Compare
bergundy
approved these changes
Oct 8, 2021
|
|
||
| export const tracer = otel.trace.getTracer('workflow'); | ||
| function getTracer(): otel.Tracer { |
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
Easier on users. They don't have to remember to call this register function
| makeWorkflowExporter, | ||
| OpenTelemetryActivityInboundInterceptor, | ||
| } from '@temporalio/interceptors-opentelemetry/lib/worker'; | ||
| import { OpenTelemetryDependencies } from '@temporalio/interceptors-opentelemetry/lib/workflow'; | ||
|
|
||
| // Un-skip this test and run it by hand to inspect outputted traces | ||
| test.skip('Otel spans connected', async (t) => { |
There was a problem hiding this comment.
How much work would it be to run this and add assertions?
Doesn't have to be in this PR but I'd at least track it.
There was a problem hiding this comment.
Not a ton. I want to do that as a follow up with fixing the sample.
Sushisource
force-pushed
the
link-run-spans
branch
from
a1d382c
to
91dc2c8
Compare
* Other various improvements to otel interceptors
Sushisource
force-pushed
the
link-run-spans
branch
from
91dc2c8
to
3820af5
Compare
Sushisource
force-pushed
the
link-run-spans
branch
from
bac236e
to
d45fe60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Links all spans in a workflow run to whatever was attached to workflow execution start headers
Why?
Best option available at the moment. Ideally everything would be part of one trace which looks best in Jaeger UI but that is currently not feasible due to open-telemetry/opentelemetry-rust#643
In theory this is maybe the more "right" way to do it, but Jaeger isn't good at displaying this sort of thing due to
jaegertracing/jaeger-ui#662
Checklist
Closes
How was this tested:
Otel manual test
Any docs updates needed?