Remove ReplicationTasksReturned (#4514)

temporalio · Jun 22, 2023 · cca978f · cca978f
1 parent 9405cf8
commit cca978f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/common/metrics/metric_defs.go b/common/metrics/metric_defs.go
@@ -1469,9 +1469,7 @@ var (
 	ReplicationTasksLag = NewTimeHistogramDef("replication_tasks_lag")
 	// ReplicationTasksFetched records the number of tasks fetched by the poller.
 	// It has the same unit issue as ReplicationTasksLag.
-	ReplicationTasksFetched = NewTimeHistogramDef("replication_tasks_fetched")
-	// ReplicationTasksReturned is the same as ReplicationTasksFetched.
-	ReplicationTasksReturned                       = NewTimeHistogramDef("replication_tasks_returned")
+	ReplicationTasksFetched                        = NewTimeHistogramDef("replication_tasks_fetched")
 	ReplicationLatency                             = NewTimerDef("replication_latency")
 	ReplicationTasksAppliedLatency                 = NewTimerDef("replication_tasks_applied_latency")
 	ReplicationDLQFailed                           = NewCounterDef("replication_dlq_enqueue_failed")

diff --git a/service/history/replication/ack_manager.go b/service/history/replication/ack_manager.go
@@ -272,9 +272,6 @@ func (p *ackMgrImpl) GetTasks(
 	p.metricsHandler.Histogram(metrics.ReplicationTasksFetched.GetMetricName(), metrics.ReplicationTasksFetched.GetMetricUnit()).
 		Record(int64(len(replicationTasks)))
 
-	p.metricsHandler.Histogram(metrics.ReplicationTasksReturned.GetMetricName(), metrics.ReplicationTasksReturned.GetMetricUnit()).
-		Record(int64(len(replicationTasks)))
-
 	replicationEventTime := timestamp.TimePtr(p.shard.GetTimeSource().Now())
 	if len(replicationTasks) > 0 {
 		replicationEventTime = replicationTasks[len(replicationTasks)-1].GetVisibilityTime()