Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to admin API in tctl list shard tasks by category #2217

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Switch to admin API in tctl list shard tasks by category #2217

merged 2 commits into from
Nov 23, 2021

Conversation

feedmeapples
Copy link
Contributor

What changed?

Switches to Admin API when listing shard tasks by category tctl admin shard list_tasks

Why?

Simplifies tctl usage by removing direct DB connection params

How did you test it?

./tctl admin shard list_tasks --shard_id 3 --task_type timer
              NAMESPACEID              |   WORKFLOWID    |                RUNID                 | TASKID  |      TASKTYPE       |            FIRETIME            | VERSION  
  3f8edc54-063c-4826-98ba-32844ef03352 | 27d82ad7###___5 | f66b1a35-23cd-4774-a8bc-81544744b0df | 1048652 | WorkflowTaskTimeout | 2021-11-22 21:08:21.275063605  |       0  
                                       |                 |                                      |         |                     | +0000 UTC                      |          
  3f8edc54-063c-4826-98ba-32844ef03352 | 047d7c9f###___2 | de43ce6a-e8d3-497e-b5d8-162b1910969b | 1048596 | ActivityTimeout     | 2021-11-22 21:26:31.658736606  |       0  
                                       |                 |                                      |         |                     | +0000 UTC                      |          
  3f8edc54-063c-4826-98ba-32844ef03352 | 047d7c9f###___3 | eaec9629-36a6-4e6d-933e-1433a27859df | 1048601 | ActivityTimeout     | 2021-11-22 21:26:31.667210198  |       0
...

Potential risks

Is hotfix candidate?

@feedmeapples feedmeapples requested a review from a team November 22, 2021 22:24
@feedmeapples feedmeapples marked this pull request as draft November 22, 2021 22:25
@feedmeapples feedmeapples marked this pull request as ready for review November 22, 2021 22:26
Base automatically changed from admin-api-shard-list-tasks to master November 23, 2021 18:03
@feedmeapples feedmeapples merged commit 769b69f into master Nov 23, 2021
@feedmeapples feedmeapples deleted the tctl-admin-list-tasks branch November 23, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @wxing1292