Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource aware operation retry #3069

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Resource aware operation retry #3069

merged 4 commits into from
Jul 7, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jul 7, 2022

What changed?

  • Add new backoff.ThrottleRetry and ThrottleRetryContext util function
  • Throttle retry will use a special throttle retry policy instead of the passed in retry policy upon resource exhausted error.
  • Change all usage of backoff.Retry and RetryContext to their throttle version.

Why?

  • Improve retry policy and don't create a retry storm upon service busy

How did you test it?

  • Unit test WIP

Potential risks

Is hotfix candidate?

  • yes.

@yycptt yycptt requested a review from yiminc July 7, 2022 00:04
yux0
yux0 approved these changes Jul 7, 2022
View reviewed changes
common/backoff/retry.go Outdated Show resolved Hide resolved
common/backoff/retry.go Outdated Show resolved Hide resolved
@yycptt yycptt marked this pull request as ready for review July 7, 2022 05:29
@yycptt yycptt requested a review from a team as a code owner July 7, 2022 05:29
@yycptt yycptt merged commit 1f4c05f into temporalio:master Jul 7, 2022
@yycptt yycptt deleted the throttle-retry branch July 7, 2022 17:32
@yycptt yycptt mentioned this pull request Jul 8, 2022
Closed
yycptt added a commit that referenced this pull request Jul 8, 2022
@yycptt
Resource aware operation retry (#3069)
0b9f15c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @yux0 @yiminc