Add config to disable ORDER BY clause #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Jul 21, 2022
alexshtin
approved these changes
Jul 25, 2022
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
alexshtin
pushed a commit
that referenced
this pull request
Jul 29, 2022
* Add config to disable ORDER BY clause * Fix unit test: add check for nil value * Move config out of history config to frontend and worker configs. * Rename config to visibilityDisableOrderByClause * Fix typo and error type * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a config to disable
ORDER BYclause for Elasticsearch. When passing anORDER BYclause when it's disabled, it will return an error.Why?
Elasticsearch can be slow to sort large amounts of documents by fields that are not indexed. This option disables this kind of operation to prevent blocking writes to ES.
How did you test it?
Passed existing unit tests, and added new unit tests.
Potential risks
The config is set to
falseat this moment, so this should be a no-op.Is hotfix candidate?
No.