Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timer task visibility timestamp for workflow refresh #3460

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix timer task visibility timestamp for workflow refresh #3460

merged 2 commits into from
Oct 11, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Oct 7, 2022

What changed?

  • Fix DeleteHistoryEventTask and WorkflowBackoffTimerTask's visibility timestamp when they are generated by workflow refresh

Why?

  • Workflow refresh will use the refresh time instead of workflow close/start time to generated those two tasks.

How did you test it?

  • Tried workflow refresh locally and verified time for generated DeleteHistoryEventTask and WorkflowBackoffTimerTask

Potential risks

Is hotfix candidate?

  • Maybe

@yycptt yycptt requested a review from a team as a code owner October 7, 2022 19:03
@yycptt yycptt merged commit 0dddd3c into temporalio:master Oct 11, 2022
@yycptt yycptt deleted the fix-task-refresher branch October 11, 2022 17:54
dnr pushed a commit that referenced this pull request Oct 17, 2022
@yycptt @dnr
Fix timer task visibility timestamp for workflow refresh (#3460)
e98b215
dnr pushed a commit that referenced this pull request Oct 18, 2022
@yycptt @dnr
Fix timer task visibility timestamp for workflow refresh (#3460)
d602bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0