Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker/README.md #350

Merged
merged 2 commits into from
May 4, 2020
Merged

Update docker/README.md #350

merged 2 commits into from
May 4, 2020

Conversation

alexshtin
Copy link
Member

What changed?
Fix markup and other minor fixes for consistency.

Why?
Fix markup and other minor fixes for consistency.

How did you test it?
Read it all.

Potential risks
No risks.

Fix markup and other minor fixes for consistency.
@alexshtin alexshtin requested a review from a team May 2, 2020 22:51
@alexshtin alexshtin changed the title Update README.md Update docker/README.md May 2, 2020
docker/README.md Outdated

Using a pre-built image
-----------------------
With every tagged release of the temporal server, there is also a corresponding
docker image that's uploaded to docker hub. In addition, the release will also
contain a **docker.tar.gz** file (docker-compose startup scripts).
Go [here](https://github.com/temporalio/temporal/releases/latest) to download a latest **docker.tar.gz**
[Download](https://github.com/temporalio/temporal/releases/latest) a latest **docker.tar.gz**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add command line way to download the release:

curl -L https://github.com/temporalio/temporal/releases/latest/download/docker.tar.gz|tar -xz

We have a bunch of places where we give curl command to download the docker-compose from master. I think all of them should be replaced with the above command.

docker/README.md Outdated
docker-compose -f docker-compose-mysql.yml up
docker-compose -f docker-compose-mysql.yml down
```bash
$ docker-compose -f docker-compose-mysql.yml up
```

Please note that SQL support is still in active developement and it is not production ready yet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with PostreSQL is not production ready yet.

docker/README.md Outdated
-----------------------------------------

Run temporal with ElasticSearch for visibility instead of Cassandra/MySQL
Run Temporal with ElasticSearch for visibility instead of Cassandra/MySQL:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with:

Run Temporal with ElasticSearch for enhanced visibility queries.

@alexshtin alexshtin merged commit a081d46 into master May 4, 2020
@alexshtin alexshtin deleted the feature/update-docker-readme branch May 4, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants