Warning log on new event during set workflow #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Oct 18, 2022
| @@ -680,7 +680,7 @@ func (c *ContextImpl) SetWorkflowExecution(ctx context.Context, now time.Time) ( | |||
| return err | |||
| } | |||
| if len(resetWorkflowEventsSeq) != 0 { | |||
| return serviceerror.NewInternal("SetWorkflowExecution encountered new events") | |||
| c.logger.Warn("SetWorkflowExecution encountered new events") | |||
There was a problem hiding this comment.
nit: also emit a metrics?
and we should revert the change before next release (1.19)
dnr
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Warning log on new event during set workflow * Add metrics for the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Warning log on new event during set workflow
Why?
Warning log on new event during set workflow
How did you test it?
Potential risks
Is hotfix candidate?