Add methods to check workflow size violations for several other fields #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
ms-limits/all-limits
branch
2 times, most recently
from
d3adf20
to
4e47e2b
Compare
MichaelSnowden
force-pushed
the
ms-limits/wf-size-checker-all-limits
branch
from
8213f82
to
3ae2811
Compare
yux0
reviewed
Nov 17, 2022
MichaelSnowden
force-pushed
the
ms-limits/wf-size-checker-all-limits
branch
from
3ae2811
to
655e2bd
Compare
yux0
reviewed
Nov 18, 2022
service/history/commandChecker.go
Outdated
Comment on lines
202
to
203
| key.RunID, | ||
| key.WorkflowID, |
There was a problem hiding this comment.
I don't mean to have the workflow id and run id in the error. Can we log an error message? Or the caller will do it?
There was a problem hiding this comment.
We do that on line 207, and the logger is tagged with those values on 187
There was a problem hiding this comment.
I've removed this from the inline error message
MichaelSnowden
force-pushed
the
ms-limits/all-limits
branch
from
4e47e2b
to
c5b27d0
Compare
MichaelSnowden
force-pushed
the
ms-limits/wf-size-checker-all-limits
branch
from
655e2bd
to
352e1c9
Compare
MichaelSnowden
force-pushed
the
ms-limits/wf-size-checker-all-limits
branch
from
352e1c9
to
647ab7a
Compare
MichaelSnowden
force-pushed
the
ms-limits/wf-size-checker-all-limits
branch
from
647ab7a
to
0819438
Compare
yux0
approved these changes
Nov 18, 2022
| numPending, | ||
| errLimit, | ||
| dynamicconfig.NumPendingChildExecutionsLimitError, | ||
| ) | ||
| logger.Error(err.Error(), tag.Error(err)) |
There was a problem hiding this comment.
nit: you can do
logger.Error("some error message",
tag.WorkflowNamespaceID(key.NamespaceID),
tag.WorkflowID(key.WorkflowID),
tag.WorkflowRunID(key.RunID),
tag.Error(err))
There was a problem hiding this comment.
Yeah, I did it this way because originally I logged a warning as well. I'll clean up in a follow up
| ) | ||
| logger.Error(err.Error(), tag.Error(err)) | ||
| return err | ||
| } | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Will do in a follow up, keeping in the interest of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I generalized our workflow size limit constraints to 4 fields (child workflows, activities, external signals, and cancel requests).
Why?
I made this change so that we can limit these fields which could potentially cause issues if they're too large.
How did you test it?
I added unit tests.
Potential risks
These new methods aren't called yet.
Is hotfix candidate?
No.