Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude history APIs from persistence health signals #4637

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Exclude history APIs from persistence health signals #4637

merged 2 commits into from
Jul 17, 2023

Conversation

pdoerner
Copy link
Contributor

What changed?

  • excluding history APIs that go to s3 from persistence health signals
  • including time to record/aggregate health signals in persistence metrics

Why?
So that issues with s3 do not slow down the whole system

How did you test it?
Existing tests

Potential risks
None

Is hotfix candidate?
No

@pdoerner pdoerner requested a review from a team as a code owner July 17, 2023 19:14
@pdoerner pdoerner requested a review from yycptt July 17, 2023 19:14
@pdoerner pdoerner self-assigned this Jul 17, 2023
@pdoerner pdoerner merged commit 72fe26c into temporalio:master Jul 17, 2023
10 checks passed
@pdoerner pdoerner deleted the health-signals-exclude-history-apis branch July 17, 2023 22:43
pdoerner added a commit that referenced this pull request Jul 21, 2023
@pdoerner
Exclude history APIs from persistence health signals (#4637)
655c51a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees

@pdoerner pdoerner

Labels
release/1.21.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdoerner @yycptt