Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all historyBuilder attributes assignments #723

Merged

Conversation

alexshtin
Copy link
Member

What changed?
All historyBuilder attributes assignments were checked for missed assigments.

Why?
Recently @mastermanu fixed one missed assignment (#712) and this PR checks all the rest and actually fixes few more.

How did you test it?
All tests.

Potential risks
No risks.

@alexshtin alexshtin force-pushed the feature/check-historybuilder-fields branch from eaa08e2 to 1bb886d Compare September 12, 2020 03:13
@alexshtin alexshtin merged commit a864df4 into temporalio:master Sep 12, 2020
@alexshtin alexshtin deleted the feature/check-historybuilder-fields branch September 12, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants