Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable button in Combobox #2181

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Disable button in Combobox #2181

merged 1 commit into from
Jul 2, 2024

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Jul 2, 2024

Description & motivation 💭

Dropdown button in Combobox component was not disabled when disabled was set to true.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 7:45pm

@laurakwhit laurakwhit merged commit 006d5e1 into main Jul 2, 2024
11 checks passed
@laurakwhit laurakwhit deleted the fix-combobox-disabled-state branch July 2, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants