Fix ExecutionStatus filters not showing up on page refresh #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
If multiple statues are selected, when the page was refreshed not all statues were showing up as a filter "chip" below the search input/filter button.
This PR fixes this by accounting for the possibility of a parenthesis as being the beginning of a search attribute in the
tokenizeutil (as in the case with "(ExecutionStatus="Running" ORExecutionStatus="TimedOut")"). It also updates several tests to have backticks for a more accurate representation of what queries look like.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
ExecutionStatusoptions from theFilterin the Workflows list viewExecutionStatusfilters show up as expectedExecutionStatusfilters show up as expectedHow was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2295Docs
Any docs updates needed?