Small CodeBlock in Modal fixes

[laurakwhit]

Description & motivation 💭

We're seeing the occasional RangeError: Invalid change range [num] to [num] (in doc of length [num]) error coming from @codemirror and it looks like it's happening for Codeblocks in Modal components. Haven't been able to reproduce, but did notice that this ⬇️ was being called twice on close in the signal confirmation modal.

ui/src/lib/components/workflow/client-actions/signal-confirmation-modal.svelte

Line 28 in 50a5e10

codeBlock?.resetView(input);

This PR calls closeModal instead of handleCancel on close buttons in the Modal component, so that open is updated to false > triggerModal is called > then modal.close() is called and finally handleCancel is only called/dispatched once. This PR also adds a destroy() for the @codemirror editor view to the CodeBlock component unmount.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

• Manual testing
• E2E tests added
• Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
holocene	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2024 7:04pm