Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UI fixes #2248

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Small UI fixes #2248

merged 2 commits into from
Aug 1, 2024

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

  • Moves the menu directly below input even if there is error in the Combobox component
  • Removes unnecessary surface-information class

Screenshots (if applicable) 📸

Before After
Screenshot 2024-08-01 at 11 07 32 AM Screenshot 2024-08-01 at 11 23 37 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from rossedfort and a team as code owners August 1, 2024 17:39
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:39pm

@laurakwhit laurakwhit merged commit 6cb9798 into main Aug 1, 2024
14 checks passed
@laurakwhit laurakwhit deleted the small-ui-fixes branch August 1, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants