Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource type attribute changes and stability fixes for yaml parsing and other config changes APE-16695, APE-16692, APE-16734 #1673

Merged
merged 42 commits into from
Mar 7, 2024

Conversation

nmoretenable
Copy link
Contributor

No description provided.

nmoretenable and others added 30 commits November 23, 2023 19:31
@nmoretenable nmoretenable changed the title Changes for Policy Remediation text and resource type changes Resource type attribute changes and stability fixes for yaml parsing and other config changes APE-16695, APE-16692, APE-16734 Mar 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 69.81982% with 134 lines in your changes are missing coverage. Please review.

Project coverage is 77.76%. Comparing base (2e75f8f) to head (ea7113a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   78.51%   77.76%   -0.76%     
==========================================
  Files         281      283       +2     
  Lines        7986     8296     +310     
==========================================
+ Hits         6270     6451     +181     
- Misses       1339     1450     +111     
- Partials      377      395      +18     
Files Coverage Δ
pkg/iac-providers/cft/v1/load-file.go 83.78% <100.00%> (ø)
...er/iac-providers/arm/config/application-gateway.go 100.00% <100.00%> (ø)
...per/iac-providers/arm/config/container-registry.go 100.00% <100.00%> (ø)
...apper/iac-providers/arm/config/cosmosdb-account.go 100.00% <100.00%> (ø)
pkg/mapper/iac-providers/arm/config/deployments.go 48.48% <100.00%> (ø)
...per/iac-providers/arm/config/diagnostic-setting.go 88.46% <100.00%> (ø)
...g/mapper/iac-providers/arm/config/key-vault-key.go 100.00% <100.00%> (ø)
...apper/iac-providers/arm/config/key-vault-secret.go 100.00% <100.00%> (ø)
pkg/mapper/iac-providers/arm/config/key-vault.go 100.00% <100.00%> (ø)
...per/iac-providers/arm/config/kubernetes-cluster.go 92.59% <100.00%> (ø)
... and 108 more

@nmoretenable nmoretenable marked this pull request as ready for review March 7, 2024 05:57
@nmoretenable nmoretenable requested a review from a team as a code owner March 7, 2024 05:57
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nmoretenable nmoretenable merged commit 4422eb5 into tenable:master Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants