Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash output improvements #431

Merged
merged 17 commits into from
Dec 16, 2020
Merged

bash output improvements #431

merged 17 commits into from
Dec 16, 2020

Conversation

patilpankaj212
Copy link
Contributor

@patilpankaj212 patilpankaj212 commented Dec 12, 2020 •
edited by cesar-rodriguez

  • implement default human readable output for terrascan scan
  • unit tests for output writers
  • change color for "File" in scan output as it is not visible on white background

Closes #168

@codecov
Copy link

codecov bot commented Dec 12, 2020 •
edited

Codecov Report

Merging #431 (c79dce5) into master (929e377) will increase coverage by 0.84%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   66.21%   67.06%   +0.84%     
==========================================
  Files          85       86       +1     
  Lines        1915     1949      +34     
==========================================
+ Hits         1268     1307      +39     
+ Misses        535      524      -11     
- Partials      112      118       +6
Impacted Files Coverage Δ
pkg/cli/register.go 4.00% <0.00%> (ø)
pkg/policy/opa/engine.go 39.01% <20.00%> (+0.33%) ⬆️
pkg/cli/scan.go 34.28% <50.00%> (+1.93%) ⬆️
pkg/termcolor/colorpatterns.go 33.33% <50.00%> (-7.15%) ⬇️
pkg/cli/run.go 62.16% <57.14%> (+22.16%) ⬆️
pkg/writer/human_readable.go 58.33% <58.33%> (ø)
pkg/policy/types.go 100.00% <100.00%> (ø)
pkg/results/types.go 100.00% <100.00%> (ø)
pkg/runtime/executor.go 94.00% <100.00%> (+0.52%) ⬆️
... and 4 more

kanchwala-yusuf
kanchwala-yusuf suggested changes Dec 14, 2020
View reviewed changes
pkg/runtime/executor.go Outdated Show resolved Hide resolved
pkg/results/types.go Outdated Show resolved Hide resolved
kanchwala-yusuf
kanchwala-yusuf reviewed Dec 14, 2020
View reviewed changes
pkg/cli/run.go Outdated Show resolved Hide resolved
pkg/cli/scan.go Show resolved Hide resolved
williepaul
williepaul suggested changes Dec 15, 2020
View reviewed changes
pkg/cli/run.go Outdated Show resolved Hide resolved
pkg/results/types.go Outdated Show resolved Hide resolved
pkg/writer/humanReadable.go Outdated Show resolved Hide resolved
pkg/cli/register.go Show resolved Hide resolved
pkg/cli/run.go Outdated Show resolved Hide resolved
pkg/runtime/executor.go Outdated Show resolved Hide resolved
williepaul
williepaul reviewed Dec 15, 2020
View reviewed changes
pkg/results/types.go Outdated Show resolved Hide resolved
williepaul
williepaul reviewed Dec 15, 2020
View reviewed changes
pkg/results/types.go Outdated Show resolved Hide resolved
williepaul
williepaul previously approved these changes Dec 15, 2020
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf merged commit 7cc4f16 into tenable:master Dec 16, 2020
@cesar-rodriguez cesar-rodriguez mentioned this pull request Jan 12, 2021
Closed
@amirbenv amirbenv linked an issue Jan 15, 2021 that may be closed by this pull request
Improved bash output #415
Closed
@patilpankaj212 patilpankaj212 deleted the human_readable_output branch May 18, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williepaul williepaul williepaul left review comments

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved bash output Terrascan print out rules in human friendly format?
3 participants
@patilpankaj212 @kanchwala-yusuf @williepaul