-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh action terrscan_atlantis release #733
Gh action terrscan_atlantis release #733
Conversation
3a654af
to
f3bd2da
Compare
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 73.86% 73.86%
=======================================
Files 110 110
Lines 3176 3176
=======================================
Hits 2346 2346
Misses 652 652
Partials 178 178 |
f3bd2da
to
6db76a0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to request changes as I don't want to block the merge, but you can improve the scripts as I made comments. :)
@@ -0,0 +1,11 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe take scripts/docker-build.sh
and tweak it so it takes DOCKER_REPO
and DIR
as parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have a PR for something like that : #555
I'll re-open it and make these changes there later. savvy?
@@ -0,0 +1,14 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this guy, see if scripts/docker-push*
can be adjusted for several images
No description provided.