Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh action terrscan_atlantis release #733

Merged
merged 2 commits into from
May 5, 2021

Conversation

devang-gaur
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #733 (6db76a0) into master (e6e6b8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files         110      110           
  Lines        3176     3176           
=======================================
  Hits         2346     2346           
  Misses        652      652           
  Partials      178      178           

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jlk jlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to request changes as I don't want to block the merge, but you can improve the scripts as I made comments. :)

@@ -0,0 +1,11 @@
#!/bin/bash

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe take scripts/docker-build.sh and tweak it so it takes DOCKER_REPO and DIR as parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have a PR for something like that : #555

I'll re-open it and make these changes there later. savvy?

@@ -0,0 +1,14 @@
#!/bin/bash

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this guy, see if scripts/docker-push* can be adjusted for several images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants