Update for modern ruby. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move version into mmap/version.rb. Update gemspec with modern settings. Update gitignore. Can now be installed with ruby 2.x.
|
Unfortunately this won't work for Ruby 1.x versions. Not sure why. So for now I've created an mmap2 gem since that wouldn't harm older code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move version into mmap/version.rb.
Update gemspec with modern settings.
Update gitignore.
Can now be installed with ruby 2.x.
This should resolve issue #6 and #1. There are some other pull requests that also fix this, but this generally stays with the way you've built it in the past.
Regardless, could one of them get merged and then released as the current mmap gem doesn't work with modern rubies.