This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
Disconnect #27
Merged
Disconnect #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -217,87 +240,115 @@ func (cli *grpcClient) finishAsyncCall(req *types.Request, res *types.Response) | |||
| return reqres | |||
| } | |||
|
|
|||
| func (cli *grpcClient) checkErrGetResult() *types.Result { | |||
There was a problem hiding this comment.
I'd just return types.Result directly, and check for res.IsOK() or res.IsErr(), just because pointers here are probably more expensive than the small types.Result structure.
And we can also do return types.ErrInternalError.SetLog(errorLog).
|
looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlushSyncchecks for errors andStopflushes the queue, fixing if a tmsp req fails on sync call, client will just hang forever on .Wait() #9