-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add genesis tests #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 69.71% 70.80% +1.08%
==========================================
Files 25 25
Lines 2262 2295 +33
==========================================
+ Hits 1577 1625 +48
+ Misses 533 528 -5
+ Partials 152 142 -10
Continue to review full report at Codecov.
|
…9-genesis-testing
also: - rename GetAllPlans to GetPlans, IterateAllPlans to IteratePlans for consistency - add k.ValidateOutstandingRewards
these methods are for convenient calculation of rewards, getting rid of the usage of cached context when calculating rewards also use Querier's Keeper field to prevent name conflict since Querier and Keeper both have Rewards method now
also fix a bug in UnpackAny that it accepts nil input or an Any with empty type url
also remove staking_reserve_coins field
When starting chain from an exported state, ValidateGenesis is not called automatically. To validate GenesisState in this case too, we call types.ValidateGenesis inside InitGenesis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Ref: #119
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes