-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create CODEOWNERS file and update contributing.md #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barriebyron CODEOWNDERS
and CONTRIBUTING.md
look good to me. However, this PR has the same commits as #188. Did you start this based off edit-farming-spec
branch?
(hanging head in shame) yes I did... bad thing. Okay, I got the unintended changes out of this PR. (whew) |
@barriebyron Thanks for resolving the unintended changes. Now this PR has two files changed. It looks like Markdown links checker found 1 dead link in |
I go to the link and the site seems to be live and there seems to be no issue. I assume either Markdown links checker was not properly checking links at the time you pushed your commit or the site was down for a moment when it checked. Let's merge this after a review from @dongsam for this PR. We need to do "Squash and Merge" this since it has lousy commits. |
94dbc38
to
9a2eb0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, I just force-pushed with resolving codecov fail by branch conflict
Description
Instead of asking our contributors to manually assign reviewers when they create a PR, let's use the CODEOWNERS file to automatically do this step. I've added myself as a docs reviewer (happy to help if I can, let's see how this goes)
Tasks
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes