Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add plan type validation for public plan proposal #225

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Nov 11, 2021

Description

closes: #219

Tasks

  • add validation logic to delete, modify handler
  • add test case for the validations
  • gofmt, go 1.17 build

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam merged commit 63d93ec into tendermint:main Nov 11, 2021
@dongsam
Copy link
Contributor Author

dongsam commented Nov 11, 2021

@hallazzang @kogisin I know it's hard to review due to the retreat, but Let me merge it first due to the release schedule. Please review it later.

@dongsam dongsam self-assigned this Nov 11, 2021
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz
Copy link
Contributor

jaybxyz commented Nov 12, 2021

LGTM as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PublicPlanProposal can modify/delete private plans
3 participants