Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor RewardsReserveAcc to be derived by deriveAddress #233

Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Nov 24, 2021

Description

closes: #XXXX

Tasks

  • refactor RewardsReserveAcc to be derived by deriveAddress ( address not changed EFD5E11CC3F9425D8B333D67F56EDB47E6994C7548C6061C455261C9BAE21E80)
  • remove caution comment on readme

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this Nov 24, 2021
@dongsam dongsam added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 24, 2021
@dongsam dongsam merged commit d729c90 into tendermint:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants