Don't encode zero values in time #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
added a commit
to liamsi/tendermint
that referenced
this pull request
Jun 13, 2018
Merged
4 tasks
melekes
approved these changes
Jun 15, 2018
|
Thanks @melekes ! |
This was referenced Jun 16, 2018
Merged
liamsi
added a commit
to liamsi/go-amino
that referenced
this pull request
Jul 4, 2018
This reverts commit eff9e54
This was referenced Jul 4, 2018
liamsi
added a commit
to liamsi/tendermint
that referenced
this pull request
Jul 18, 2018
liamsi
added a commit
that referenced
this pull request
Aug 17, 2018
* DecodeInt{8, 16} negative limit checks + tests (#125)
Updates #120
Also adds a test for Byteslice encoding and decoding
roundtripping and part slicing then rejoining.
* fix circleci2.0
* some metalinter issues
* skip over default values when encoding time (#178)
* do not encode empty structs, unless `amino:"write_empty"` is set (#179)
* skip over empty structs by default
* slightly more info on panics
* Fix zero time decoding (#190)
- fix decoding of skipped fields in time, or completely skipped time
- necessary because sec=0 and ns=0 do not result in time.Time{} and vice versa
* Prepare release 0.11.0 (#193)
* Fix time decoding & encoding of arrays and structs
- top-level entry functions called with BinFieldNum:1 to properly encode e.g. arrays of structs (see non-time related test)
- add defaultValue method, different from #196 it deals with multiply nested pointers
* Removed dependency on tmlibs/common
* Always write empty if struct field is pointer
* add tests for #206
- test for pointers to empty struct and nil pointer
* fix proto3 compatibility for empty structs
* Add EmptyStruct to fuzz tests
* Revert "fix proto3 compatibility for empty structs"
* Do not allow encoding of nil struct pointers in a slice/array
* By default, 0-length list elements are decoded as nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip over default values (zeroes) in
EncodeTime(as proto3 does).