This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
SignatureKey -> Signature #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, will add something that prints a table in markdown. This can be copy & pasted to update the documentation. Be aware that this also requires changes in amino though. (everything related to the type info is currently not exported). |
|
How does this look to you:
|
This was referenced May 31, 2018
|
updated the docs here: https://github.com/Liamsi/tendermint-1/blob/978277a4c18258a8aaa1a829c4924a31e96d9270/docs/spec/blockchain/encoding.md I'm wondering if we even need the "Notes" column? /cc @ebuchman |
Seems not, at least for now |
liamsi
added a commit
to liamsi/tendermint
that referenced
this pull request
Jun 2, 2018
according to: tendermint/go-crypto#110 (comment)
OK, (manually) removed it in tendermint/tendermint#1662 |
|
@liamsi Let's fix for |
include an example, do not err check on info ... bur for empty info instead
…name # Conflicts: # Gopkg.lock # keys/keybase_test.go # signature_test.go
|
PTAL @xla |
🍡
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84
@liamsi can you add #88 so we can get the updated info for the docs: https://github.com/tendermint/tendermint/blob/master/docs/spec/blockchain/encoding.md#pubkeyed25519
We can probably simplify those docs a bunch by just using a table instead of all the verbosity I have there now ...