Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for swagger #172

Merged
merged 6 commits into from
Mar 17, 2021
Merged

Suggestions for swagger #172

merged 6 commits into from
Mar 17, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Mar 16, 2021

Description

top-level text review for accuracy and clarity for Swagger HTTP API doc (2.1.1) command list

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #172 (d6257b1) into develop (1572795) will increase coverage by 1.15%.
The diff coverage is 80.43%.

❗ Current head d6257b1 differs from pull request most recent head e433547. Consider uploading reports for the commit e433547 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #172      +/-   ##
===========================================
+ Coverage    79.45%   80.61%   +1.15%     
===========================================
  Files           20       20              
  Lines         2259     2291      +32     
===========================================
+ Hits          1795     1847      +52     
+ Misses         261      240      -21     
- Partials       203      204       +1     
Impacted Files Coverage Δ
x/liquidity/types/utils.go 100.00% <ø> (ø)
x/liquidity/keeper/invariants.go 56.41% <50.98%> (-38.33%) ⬇️
x/liquidity/simulation/operations.go 75.09% <64.81%> (ø)
x/liquidity/types/liquidity_pool.go 76.25% <73.07%> (-7.32%) ⬇️
x/liquidity/keeper/liquidity_pool.go 77.69% <79.92%> (+1.69%) ⬆️
x/liquidity/types/genesis.go 81.81% <83.33%> (ø)
x/liquidity/keeper/swap.go 85.60% <84.00%> (+23.67%) ⬆️
x/liquidity/keeper/genesis.go 80.95% <87.50%> (+0.95%) ⬆️
x/liquidity/types/swap.go 81.27% <88.00%> (+1.40%) ⬆️
x/liquidity/keeper/store.go 88.77% <90.62%> (-0.04%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea45ef...e433547. Read the comment docs.

@barriebyron barriebyron self-requested a review March 16, 2021 15:16
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants