Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidity Pool module Swagger documentation QA (2.2.1) #222

Closed
wants to merge 2 commits into from

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Apr 14, 2021

Description

It is PR to get the swagger documentation QA suggestions based on the sources, continues to after #172, #188, #206

The commit of this PR consists of a .proto, swagger file diff to receive reviews and suggestions comments and is not for merge purposes, so please ignore the conflicts

@dongsam dongsam added the documentation Improvements or additions to documentation label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #222 (86b1a3b) into develop (007913d) will not change coverage.
The diff coverage is n/a.

❗ Current head 86b1a3b differs from pull request most recent head b54b933. Consider uploading reports for the commit b54b933 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #222   +/-   ##
========================================
  Coverage    83.43%   83.43%           
========================================
  Files           20       20           
  Lines         2349     2349           
========================================
  Hits          1960     1960           
  Misses         209      209           
  Partials       180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007913d...b54b933. Read the comment docs.

@barriebyron barriebyron changed the title Continually Suggestions for Swagger documentation QA (2.2.1) Liquidity Pool module Swagger documentation QA (2.2.1) Apr 14, 2021
@barriebyron
Copy link
Contributor

@dongsam I lost track of what we're looking at here. Can you update this PR, branch, fork or whatever we need so that the files you want me to look at are visible in the Files Changes tab? Or a link to the files in the repo? I appreciate your help.

@dongsam
Copy link
Contributor Author

dongsam commented Apr 27, 2021

@dongsam I lost track of what we're looking at here. Can you update this PR, branch, fork or whatever we need so that the files you want me to look at are visible in the Files Changes tab? Or a link to the files in the repo? I appreciate your help.

@barriebyron I re-open PR #235 with diff for files targeted QA, so let me close this PR and please continue on #235

@dongsam dongsam closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants