Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto-js-gen command and re-generate js client #225

Merged

Conversation

hallazzang
Copy link
Contributor

Description

closes: #224


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #225 (a7eaeb3) into develop (45cacb8) will not change coverage.
The diff coverage is n/a.

❗ Current head a7eaeb3 differs from pull request most recent head fb822d1. Consider uploading reports for the commit fb822d1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    82.84%   82.84%           
========================================
  Files           20       20           
  Lines         2215     2215           
========================================
  Hits          1835     1835           
  Misses         209      209           
  Partials       171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cacb8...fb822d1. Read the comment docs.

@dongsam
Copy link
Contributor

dongsam commented Apr 20, 2021

@hallazzang Looks good to me 👍, The result may vary depending on the starport version of the local environment, I think it would be better to specify the version in the Makefile, and occur warning when the version does not match.

@clockworkgr Which version of starport should we use for the liquidity module? latest release version? currently v0.15.1

Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me merge first for audit and Incentivize testnet, and then we can continue with a separate PR to add a variable for specific starport version

@dongsam dongsam merged commit 466842a into tendermint:develop Apr 21, 2021
@clockworkgr
Copy link
Contributor

@hallazzang Looks good to me , The result may vary depending on the starport version of the local environment, I think it would be better to specify the version in the Makefile, and occur warning when the version does not match.

@clockworkgr Which version of starport should we use for the liquidity module? latest release version? currently v0.15.1

This was actually built with the develop version of starport (which will be v0.16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generation scripts for ts/js files
3 participants