update genesis.proto #373
Merged
update genesis.proto #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using proto/tendermint/liquidity/v1beta1/genesis.proto in https://github.com/tendermint/liquidity/pull/235/files I am making the suggested changes here seems simpler and will enable us to disposition each small change quickly and iteratively
Codecov Report
@@ Coverage Diff @@
## develop #373 +/- ##
========================================
Coverage 83.09% 83.09%
========================================
Files 20 20
Lines 2248 2248
========================================
Hits 1868 1868
Misses 208 208
Partials 172 172 Continue to review full report at Codecov.
|
|
As @hallazzang comments in this #373, the generation of the corresponding *.pb.go files is needed when there is a change in any of the |
jaybxyz
approved these changes
May 31, 2021
dongsam
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using proto/tendermint/liquidity/v1beta1/genesis.proto in https://github.com/tendermint/liquidity/pull/235/files
I am making the suggested changes to genesis.proto here
seems simpler and will enable us to disposition each small change quickly and iteratively
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes