This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Fix warning for dynamic trait objects #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update protobuf to 2.8
Merged
tomtau
added a commit
that referenced
this pull request
Aug 23, 2019
* add crates.io badge (#73) * update to tendermint v0.32 (#77) * Compatibility Table, Fix link in toml (#81) - Added table for compatiblity - fix link in toml - homepage link closes #58 & #74 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Reduce amount of logs under `info` (#80) closes #78 - Reduce amount of logs to clean up terminal if just running the abci server Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add changelog (#82) * Add changelog - Added a Changelog closes #65 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix dynamic trait warning (#84) Update protobuf to 2.8 * Release/v0.6.1 (#85) * updated cargo + changelog * Fix edition + bump dependencies * fix changelog entry
tomtau
pushed a commit
that referenced
this pull request
Sep 27, 2019
* add crates.io badge (#73) * update to tendermint v0.32 (#77) * Compatibility Table, Fix link in toml (#81) - Added table for compatiblity - fix link in toml - homepage link closes #58 & #74 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Reduce amount of logs under `info` (#80) closes #78 - Reduce amount of logs to clean up terminal if just running the abci server Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add changelog (#82) * Add changelog - Added a Changelog closes #65 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix dynamic trait warning (#84) Update protobuf to 2.8 * Release/v0.6.1 (#85) * updated cargo + changelog * Fix edition + bump dependencies * fix changelog entry * Update env_logger requirement from 0.6.2 to 0.7.0 (#88) Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.2...v0.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bumped version of protobuf to 2.8.1 -- fixes #87 (#89) * updated readme
tomtau
pushed a commit
that referenced
this pull request
Nov 11, 2019
* add crates.io badge (#73) * update to tendermint v0.32 (#77) * Compatibility Table, Fix link in toml (#81) - Added table for compatiblity - fix link in toml - homepage link closes #58 & #74 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Reduce amount of logs under `info` (#80) closes #78 - Reduce amount of logs to clean up terminal if just running the abci server Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add changelog (#82) * Add changelog - Added a Changelog closes #65 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix dynamic trait warning (#84) Update protobuf to 2.8 * Release/v0.6.1 (#85) * updated cargo + changelog * Fix edition + bump dependencies * fix changelog entry * Update env_logger requirement from 0.6.2 to 0.7.0 (#88) Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.2...v0.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bumped version of protobuf to 2.8.1 -- fixes #87 (#89) * Bumped version of protobuf to 2.8.1 -- fixes #87 * updated readme * Fix CONTRIBUTING.md link in PR template (#92) * Fix typo in README (#91) * Reduce the number of tokio dependencies (#94) * Update futures requirement from 0.1 to 0.3 (#97) Updates the requirements on [futures](https://github.com/rust-lang-nursery/futures-rs) to permit the latest version. - [Release notes](https://github.com/rust-lang-nursery/futures-rs/releases) - [Changelog](https://github.com/rust-lang-nursery/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@futures-cpupool-0.1.1...0.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Release for 0.6.3 (#98) * Release for 0.6.3 - changes to get ready for new release Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entries
tomtau
added a commit
that referenced
this pull request
Jun 30, 2020
* add crates.io badge (#73) * update to tendermint v0.32 (#77) * Compatibility Table, Fix link in toml (#81) - Added table for compatiblity - fix link in toml - homepage link closes #58 & #74 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Reduce amount of logs under `info` (#80) closes #78 - Reduce amount of logs to clean up terminal if just running the abci server Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add changelog (#82) * Add changelog - Added a Changelog closes #65 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix dynamic trait warning (#84) Update protobuf to 2.8 * Release/v0.6.1 (#85) * updated cargo + changelog * Fix edition + bump dependencies * fix changelog entry * Update env_logger requirement from 0.6.2 to 0.7.0 (#88) Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.2...v0.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bumped version of protobuf to 2.8.1 -- fixes #87 (#89) * Bumped version of protobuf to 2.8.1 -- fixes #87 * updated readme * Fix CONTRIBUTING.md link in PR template (#92) * Fix typo in README (#91) * Reduce the number of tokio dependencies (#94) * Update futures requirement from 0.1 to 0.3 (#97) Updates the requirements on [futures](https://github.com/rust-lang-nursery/futures-rs) to permit the latest version. - [Release notes](https://github.com/rust-lang-nursery/futures-rs/releases) - [Changelog](https://github.com/rust-lang-nursery/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@futures-cpupool-0.1.1...0.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Release for 0.6.3 (#98) * Release for 0.6.3 - changes to get ready for new release Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entries * Worker panic leave mutex in poisoned status (#100) Solution: propagate panic to quit the whole server. * updated docs for 0.6.4 (#101) * Fix username link (#103) * fix bug in readme (#108) * Upgrade protobuf to 2.10.0 (#110) * bumped version to 0.6.5 + changelog entry * proto: update proto files & add third_party (#116) abci updated to 0.33 * doc: updated README and CHANGELOG for 0.7.0 (#117) * release v0.7 (#118) (#124) * proto: update proto files & add third_party (#116) abci updated to 0.33 * doc: updated README and CHANGELOG for 0.7.0 (#117) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> * dep: bump proto dep (#123) closes #122 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * ci: move part of ci to github actions (#129) Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * updated protobuf definitions to TM 0.33.5 + crates (fixes #130 fixes #128) (#131) * doc: updated CHANGELOG for 0.7.1 Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Alex Manuskin <amanusk@protonmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Nicolas <abramlujan@gmail.com> Co-authored-by: Andy Weiss <wvvwwvw@gmail.com> Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Jackson Lewis <inquisitivepenguin@protonmail.com> Co-authored-by: Rob Kelly <Robert.l.kelly3@gmail.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
tomtau
added a commit
that referenced
this pull request
Jul 24, 2020
* add crates.io badge (#73) * update to tendermint v0.32 (#77) * Compatibility Table, Fix link in toml (#81) - Added table for compatiblity - fix link in toml - homepage link closes #58 & #74 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Reduce amount of logs under `info` (#80) closes #78 - Reduce amount of logs to clean up terminal if just running the abci server Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add changelog (#82) * Add changelog - Added a Changelog closes #65 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix dynamic trait warning (#84) Update protobuf to 2.8 * Release/v0.6.1 (#85) * updated cargo + changelog * Fix edition + bump dependencies * fix changelog entry * Update env_logger requirement from 0.6.2 to 0.7.0 (#88) Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.2...v0.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bumped version of protobuf to 2.8.1 -- fixes #87 (#89) * Bumped version of protobuf to 2.8.1 -- fixes #87 * updated readme * Fix CONTRIBUTING.md link in PR template (#92) * Fix typo in README (#91) * Reduce the number of tokio dependencies (#94) * Update futures requirement from 0.1 to 0.3 (#97) Updates the requirements on [futures](https://github.com/rust-lang-nursery/futures-rs) to permit the latest version. - [Release notes](https://github.com/rust-lang-nursery/futures-rs/releases) - [Changelog](https://github.com/rust-lang-nursery/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@futures-cpupool-0.1.1...0.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Release for 0.6.3 (#98) * Release for 0.6.3 - changes to get ready for new release Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entries * Worker panic leave mutex in poisoned status (#100) Solution: propagate panic to quit the whole server. * updated docs for 0.6.4 (#101) * Fix username link (#103) * fix bug in readme (#108) * Upgrade protobuf to 2.10.0 (#110) * bumped version to 0.6.5 + changelog entry * proto: update proto files & add third_party (#116) abci updated to 0.33 * doc: updated README and CHANGELOG for 0.7.0 (#117) * release v0.7 (#118) (#124) * proto: update proto files & add third_party (#116) abci updated to 0.33 * doc: updated README and CHANGELOG for 0.7.0 (#117) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> * dep: bump proto dep (#123) closes #122 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * ci: move part of ci to github actions (#129) Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * updated protobuf definitions to TM 0.33.5 + crates (fixes #130 fixes #128) (#131) * doc: updated CHANGELOG for 0.7.1 * upgraded dependencies (tokio, bytes, protobuf) (#138) rewrote the server routine to use async-await, as tokio 0.2 requires it (encoder/decoder are now in tokio_util crate; used tokio sync Mutex instead of std) added a panic hook, as otherwise the runtime may hang if internal app panics. as there's no way for apps to be signalled that connection dropped, there's an explicit panic now (so the app can restart from the committed state) Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Alex Manuskin <amanusk@protonmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Nicolas <abramlujan@gmail.com> Co-authored-by: Andy Weiss <wvvwwvw@gmail.com> Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Jackson Lewis <inquisitivepenguin@protonmail.com> Co-authored-by: Rob Kelly <Robert.l.kelly3@gmail.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
trait objects without an explicit dyn are deprecatedwarningStarting rust stable version 1.37.0, the old syntax for trait object emits errors.
Similarly, the updated protobuf version generates files adhering to the new standard.
Reopened against develop as requested in #83
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]Reviewed
Files changedin the github PR explorerBump Tendermint & ABCI version in README.md if version was updated
For Admin Use: