Greg/private networks #1454
Closed
Greg/private networks #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1454 +/- ##
===========================================
- Coverage 63.67% 63.64% -0.03%
===========================================
Files 102 102
Lines 9459 9452 -7
===========================================
- Hits 6023 6016 -7
- Misses 2871 2873 +2
+ Partials 565 563 -2
|
|
@greg-szabo have you seen the "addr_book_strict" option in the config ? Does that work ? Maybe we can expose it as a flag if need be ? Not sure we want to just remove this kind of check out right |
|
I wrote a long dissection of the RFCs on the issue. All in all, I agree: we should remove this kind of check outright. |
|
Closing it, as agreed on the meeting. |
melekes
added a commit
that referenced
this pull request
Apr 24, 2018
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 24, 2018
melekes
added a commit
that referenced
this pull request
Apr 26, 2018
* [cmd] Turn off strict routability when using testnet cmd Refs #1454 * use "testnet" instead of "it"
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
) Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.3.0 to 0.4.0. - [Commits](golang/sync@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the use of private IPv4 addresses. (RFC1918). This is required to run tendermint on a private network where all the nodes are on the same private network.